Add requireTypeCheck option to guard-super-call #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
reviewed
Jul 25, 2024
| }, | ||
|
|
||
| create(context): Rule.RuleListener { | ||
| let insideNonNativeElement = false; | ||
| let errNode = null; | ||
| const source = context.getSourceCode(); | ||
| const options = context.options?.[0] ?? {}; | ||
| const requireTypeCheck = options.requireTypeCheck ?? false; |
There was a problem hiding this comment.
its probably better to just compare here, like options.requireTypeCheck === true
43081j
reviewed
Jul 25, 2024
| } | ||
| }, | ||
| schema: [{ | ||
| requireTypeCheck: {type: 'boolean'} |
There was a problem hiding this comment.
this object is meant to have a type i think, like:
schema: [
{
type: 'object',
properties: {
requireTypeCheck: {type: 'boolean'}
}
}
]
43081j
reviewed
Jul 25, 2024
| @@ -100,7 +119,11 @@ const rule: Rule.RuleModule = { | |||
| if (isSuperHookExpression(node, hook)) { | |||
| errNode = node; | |||
| return true; | |||
| } else if (node.type === 'IfStatement' && !isSuperHook(node.test, hook)) { | |||
There was a problem hiding this comment.
i think i'd leave this as it is and just change isSuperHook to accept an extra requireTypeCheck parameter
inside isSuperHook, we could then:
if (requireTypeCheck) {
return /* whatever a type checked super hook looks like */
}
return /* whatever a regular super hook looks like */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #134.